rdblue commented on code in PR #3457:
URL: https://github.com/apache/iceberg/pull/3457#discussion_r990829299
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/BaseSparkAction.java:
##########
@@ -151,17 +160,27 @@ protected Dataset<FileInfo> contentFileDS(Table table) {
.repartition(numShufflePartitions) // avoid adaptive execution
combining tasks
.as(ManifestFileBean.ENCODER);
- return allManifests.flatMap(new ReadManifest(tableBroadcast),
FileInfo.ENCODER);
+ return allManifestsBean.flatMap(new ReadManifest(tableBroadcast),
FileInfo.ENCODER);
}
protected Dataset<FileInfo> manifestDS(Table table) {
- return loadMetadataTable(table, ALL_MANIFESTS)
- .select(col("path"), lit(MANIFEST).as("type"))
- .as(FileInfo.ENCODER);
+ return manifestDS(table, null);
+ }
+
+ protected Dataset<FileInfo> manifestDS(Table table, Set<Long> snapshots) {
+ Dataset<Row> allManifests = loadMetadataTable(table, ALL_MANIFESTS);
+ if (snapshots != null) {
+ allManifests = filterAllManifests(allManifests, snapshots);
Review Comment:
Nit: preserving the use of `all` makes this awkward after filtering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
