rdblue commented on code in PR #3457:
URL: https://github.com/apache/iceberg/pull/3457#discussion_r990830055
##########
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestExpireSnapshotsAction.java:
##########
@@ -1250,4 +1252,70 @@ public void testExpireAfterExecute() {
List<Row> untypedExpiredFiles = action.expire().collectAsList();
Assert.assertEquals("Expired results must match", 1,
untypedExpiredFiles.size());
}
+
+ @Test
+ public void testExpireFileDeletionMostExpired() {
+ testExpireFilesAreDeleted(5, 2);
+ }
+
+ @Test
+ public void testExpireFileDeletionMostRetained() {
+ testExpireFilesAreDeleted(2, 5);
+ }
+
+ public void testExpireFilesAreDeleted(int dataFilesExpired, int
dataFilesRetained) {
Review Comment:
I think this test is okay, but I think that it doesn't really test cases
where the retained and deleted files are mixed together. That deserves a direct
test, where the `deleteCandidateFileDS` actually contains files in the
`validFileDS`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
