szehon-ho commented on code in PR #5622:
URL: https://github.com/apache/iceberg/pull/5622#discussion_r996182604
##########
spark/v3.0/spark/src/main/java/org/apache/iceberg/spark/actions/BaseMigrateTableSparkAction.java:
##########
@@ -95,6 +97,12 @@ public MigrateTable tableProperty(String property, String
value) {
return this;
}
+ @Override
+ public MigrateTable dropBackup(boolean dropBackup) {
+ this.removeBackup = dropBackup;
Review Comment:
Can we rename the variables to be the same (either remove or drop). It
makes the code easier if there's fewer concepts, and we keep the same variable
name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
