szehon-ho commented on code in PR #5622:
URL: https://github.com/apache/iceberg/pull/5622#discussion_r996231152
##########
spark/v3.0/spark/src/main/java/org/apache/iceberg/spark/actions/BaseMigrateTableSparkAction.java:
##########
@@ -95,6 +97,12 @@ public MigrateTable tableProperty(String property, String
value) {
return this;
}
+ @Override
+ public MigrateTable dropBackup(boolean dropBackup) {
+ this.removeBackup = dropBackup;
Review Comment:
OK sorry, i guess it breaks the checkstyle :(.
After taking a look through other Iceberg interfaces, I think nobody passes
a boolean but just have a no-arg method. Can we do that instead? Thanks.
ie.
dropBackup() {
this.dropBackup = true;
return this;
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
