rdblue commented on code in PR #5949: URL: https://github.com/apache/iceberg/pull/5949#discussion_r996208857
########## python/pyiceberg/io/pyarrow.py: ########## @@ -23,10 +23,16 @@ """ import os -from functools import lru_cache -from typing import Callable, Tuple, Union +from functools import lru_cache, singledispatch +from typing import ( + Callable, + List, + Tuple, + Union, +) from urllib.parse import urlparse +import pyarrow as pa Review Comment: Is this file the right location for `pyarrow` conversions? This is an implementation of `FileIO` so I don't know that it fits to put schema conversion here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
