Fokko commented on code in PR #5949: URL: https://github.com/apache/iceberg/pull/5949#discussion_r996659966
########## python/pyiceberg/io/pyarrow.py: ########## @@ -23,10 +23,16 @@ """ import os -from functools import lru_cache -from typing import Callable, Tuple, Union +from functools import lru_cache, singledispatch +from typing import ( + Callable, + List, + Tuple, + Union, +) from urllib.parse import urlparse +import pyarrow as pa Review Comment: I was also not sure, but it felt like me the right place mainly because PyArrow is optional, and if so, we only need to be careful not to import this Python module. If we would put it in `schema.py`, then we need to have logic to make sure that it is optional, and if you don't have pyarrow installed, everything still works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
