danielcweeks commented on code in PR #5998:
URL: https://github.com/apache/iceberg/pull/5998#discussion_r997532396
##########
core/src/main/java/org/apache/iceberg/rest/RESTCatalog.java:
##########
@@ -46,7 +47,9 @@
private final SupportsNamespaces nsDelegate;
public RESTCatalog() {
- this(SessionCatalog.SessionContext.createEmpty(), new HTTPClientFactory());
+ this(
+ SessionCatalog.SessionContext.createEmpty(),
+ config ->
HTTPClient.builder().uri(config.get(CatalogProperties.URI)).build());
Review Comment:
Are you suggesting just passing the config to the builder instead of passing
the URI? Currently, that's the only value that would be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
