nastra commented on code in PR #5998:
URL: https://github.com/apache/iceberg/pull/5998#discussion_r997811772
##########
core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java:
##########
@@ -182,9 +181,8 @@ private static String
addRequestTestCaseAndGetPath(HttpMethod method, Item body,
request("/" + path)
.withMethod(method.name().toUpperCase(Locale.ROOT))
.withHeader("Authorization", "Bearer " + BEARER_AUTH_TOKEN)
- .withHeader(HTTPClientFactory.CLIENT_VERSION_HEADER,
icebergBuildFullVersion)
- .withHeader(
- HTTPClientFactory.CLIENT_GIT_COMMIT_SHORT_HEADER,
icebergBuildGitCommitShort);
+ .withHeader(HTTPClient.CLIENT_VERSION_HEADER,
icebergBuildFullVersion)
+ .withHeader(HTTPClient.CLIENT_GIT_COMMIT_SHORT_HEADER,
icebergBuildGitCommitShort);
Review Comment:
this is building the expected request for the mock http server. If a request
that matches this expectation arrives, the mock server will respond with the
configured response in `mockServer.when(mockRequest).respond(mockResponse)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
