amogh-jahagirdar commented on code in PR #5150:
URL: https://github.com/apache/iceberg/pull/5150#discussion_r1001002583
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkReadOptions.java:
##########
@@ -35,6 +35,12 @@ private SparkReadOptions() {}
// A timestamp in milliseconds; the snapshot used will be the snapshot
current at this time.
public static final String AS_OF_TIMESTAMP = "as-of-timestamp";
+ // branch ref of the table snapshot to read from
+ public static final String BRANCH = "branch";
+
+ // tag ref of the table snapshot to read from
Review Comment:
Just a nit: I think for the comments we can leave off the "table snapshot"
and "ref" part and the comment could look something like
"Tag to read from"
"Branch to read from"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
