amogh-jahagirdar commented on code in PR #5150:
URL: https://github.com/apache/iceberg/pull/5150#discussion_r1008787248
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkBatchQueryScan.java:
##########
@@ -270,6 +282,8 @@ && readSchema().equals(that.readSchema())
&& Objects.equals(startSnapshotId, that.startSnapshotId)
&& Objects.equals(endSnapshotId, that.endSnapshotId)
&& Objects.equals(asOfTimestamp, that.asOfTimestamp);
+ // && Objects.equals(branch, that.branch)
+ // && Objects.equals(tag, that.tag);
}
Review Comment:
Considering it's required for a correct equals implementation of
SparkBatchQueryScan, I think it makes the most sense just to suppress the
warnings on the method `@SuppressWarnings("checkstyle:CyclomaticComplexity")`
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -226,6 +222,12 @@ public Scan build() {
scan = scan.asOfTime(asOfTimestamp);
}
+ if (branch != null) {
+ scan.useRef(branch);
+ } else if (tag != null) {
+ scan.useRef(tag);
+ }
Review Comment:
No problem!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
