rdblue commented on code in PR #6128:
URL: https://github.com/apache/iceberg/pull/6128#discussion_r1027341882
##########
python/tests/test_transforms.py:
##########
@@ -874,7 +874,7 @@ def
test_projection_truncate_long_literal_eq(bound_reference_long: BoundReferenc
def test_projection_truncate_long_literal_gt(bound_reference_long:
BoundReference) -> None:
assert TruncateTransform(2).project(
"name", BoundGreaterThan(term=bound_reference_long,
literal=DecimalLiteral(Decimal(19.25)))
- ) == GreaterThanOrEqual(term="name", literal=Decimal("20.24"))
+ ) == GreaterThanOrEqual(term="name", literal=Decimal("19.26"))
Review Comment:
I think this test is incorrect because the reference is for a decimal
column. The adjustment to the literal is probably correct, but we should never
have a case where a bound expression contains a term that doesn't match the
literal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
