Fokko commented on code in PR #6258:
URL: https://github.com/apache/iceberg/pull/6258#discussion_r1033516566
##########
python/pyiceberg/expressions/visitors.py:
##########
@@ -185,7 +185,7 @@ def _(obj: Or, visitor: BooleanExpressionVisitor[T]) -> T:
return visitor.visit_or(left_result=left_result, right_result=right_result)
-def bind(schema: Schema, expression: BooleanExpression, case_sensitive: bool)
-> BooleanExpression:
+def bind(schema: Schema, expression: BooleanExpression, case_sensitive: bool =
True) -> BooleanExpression:
Review Comment:
I also made this one mandatory again, so we don't accidentally forget to set
it ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
