rdblue commented on code in PR #6258:
URL: https://github.com/apache/iceberg/pull/6258#discussion_r1033851034
##########
python/pyiceberg/table/__init__.py:
##########
@@ -355,7 +355,23 @@ def to_arrow(self):
if "*" not in self.selected_fields:
columns = list(self.selected_fields)
- return pq.read_table(source=locations, filesystem=fs, columns=columns)
+ pyarrow_filter = None
+ if self.row_filter is not AlwaysTrue():
+ bound_row_filter = bind(self.table.schema(), self.row_filter)
+ pyarrow_filter = expression_to_pyarrow(bound_row_filter)
+
+ from pyarrow.dataset import dataset
+
+ ds = dataset(
+ source=locations,
+ filesystem=fs,
+ # Optionally provide the Schema for the Dataset,
+ # in which case it will not be inferred from the source.
+ #
https://arrow.apache.org/docs/python/generated/pyarrow.dataset.dataset.html#pyarrow.dataset.dataset
+ schema=schema_to_pyarrow(self.table.schema()),
Review Comment:
What I mean is that this probably needs to use the field names from each
Parquet data file, not the field names from the table schema. That's because
Parquet typically projects columns by name, but Iceberg uses IDs. There's no
guarantee that the file's column names match the table's column names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
