rdblue commented on code in PR #6274:
URL: https://github.com/apache/iceberg/pull/6274#discussion_r1035417990
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -758,20 +758,6 @@ protected Map<String, String> summary() {
return summaryBuilder.build();
}
- /**
- * Apply the update's changes to the base table metadata and return the new
manifest list.
- *
- * @param base the base table metadata to apply changes to
- * @return a manifest list for the new snapshot.
- * @deprecated Will be removed in 1.2.0, use {@link
MergingSnapshotProducer#apply(TableMetadata,
- * Snapshot)}.
- */
- @Deprecated
- @Override
- public List<ManifestFile> apply(TableMetadata base) {
Review Comment:
Why remove these? It doesn't seem like a big deal to keep the versions that
default the parent snapshot to current.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
