rdblue commented on code in PR #6274:
URL: https://github.com/apache/iceberg/pull/6274#discussion_r1035421234
##########
spark/v3.1/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteMergeInto.scala:
##########
@@ -228,13 +225,6 @@ case class RewriteMergeInto(spark: SparkSession) extends
Rule[LogicalPlan] with
}
}
- private def isCardinalityCheckEnabled(table: Table): Boolean = {
- PropertyUtil.propertyAsBoolean(
- table.properties(),
- MERGE_CARDINALITY_CHECK_ENABLED,
Review Comment:
Okay, it looks like this property is still used by Spark 3.1, so we
shouldn't actually remove it (or the ability to disable it!) until we remove
support for 3.1.
##########
spark/v3.1/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMerge.java:
##########
@@ -370,48 +369,6 @@ public void testMergeWithMultipleUpdatesForTargetRow() {
sql("SELECT * FROM %s ORDER BY id ASC NULLS LAST", tableName));
}
- @Test
- public void testMergeWithDisabledCardinalityCheck() {
Review Comment:
I think this is still valid for 3.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
