kmozaid commented on code in PR #6410:
URL: https://github.com/apache/iceberg/pull/6410#discussion_r1046006735
##########
api/src/main/java/org/apache/iceberg/metrics/MetricsReporter.java:
##########
@@ -18,10 +18,16 @@
*/
package org.apache.iceberg.metrics;
+import java.util.Map;
+
/** This interface defines the basic API for reporting metrics for operations
to a Table. */
@FunctionalInterface
public interface MetricsReporter {
+ default void init(Map<String, String> properties) {
Review Comment:
sure, I can rename, As of now I don't have use case to supply any
properties, though one could pass prometheus gateway url or any other rest api
where custom metrics reporter can push. (although these info can be directly
read for static properties file that custom metric reporter will be dependent
on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
