stevenzwu commented on code in PR #6407:
URL: https://github.com/apache/iceberg/pull/6407#discussion_r1046225363
##########
core/src/main/java/org/apache/iceberg/SerializableTable.java:
##########
@@ -357,6 +357,12 @@ public Transaction newTransaction() {
throw new UnsupportedOperationException(errorMsg("newTransaction"));
}
+ @Override
+ public IncrementalAppendScan newIncrementalAppendScan() {
+ TableOperations ops = new StaticTableOperations(metadataFileLocation, io,
locationProvider);
+ return new BaseIncrementalAppendScan(ops, lazyTable());
Review Comment:
should this be `lazyTable().newIncrementalAppendScan`?
nit: please move this method next to `newScan()` above following the same
order as `Table` interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
