stevenzwu commented on code in PR #6407:
URL: https://github.com/apache/iceberg/pull/6407#discussion_r1046606070
##########
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##########
@@ -357,13 +358,10 @@ public IcebergSource<T> build() {
if (readerFunction == null) {
RowDataReaderFunction rowDataReaderFunction =
new RowDataReaderFunction(
+ (SerializableTable) SerializableTable.copyOf(table),
flinkConfig,
- table.schema(),
context.project(),
- context.nameMapping(),
Review Comment:
this essentially deprecates `ScanContext#nameMapping` and only retrieve from
table property. Technically, this breaks backward compatibility. is there any
use case where Flink job needs to set a different name mapping than table
property?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
