szehon-ho commented on code in PR #6661:
URL: https://github.com/apache/iceberg/pull/6661#discussion_r1093539407


##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -47,7 +48,11 @@ public class PartitionsTable extends BaseMetadataTable {
             Types.NestedField.required(1, "partition", 
Partitioning.partitionType(table)),
             Types.NestedField.required(2, "record_count", 
Types.LongType.get()),
             Types.NestedField.required(3, "file_count", 
Types.IntegerType.get()),
-            Types.NestedField.required(4, "spec_id", Types.IntegerType.get()));

Review Comment:
   @RussellSpitzer I think it was , we should keep ids/names but not 
necessarily order.  Ref: 
https://github.com/apache/iceberg/pull/3015#issuecomment-951133690
   
   Didn't see we broke anything that time, we resolved 
https://github.com/apache/iceberg/pull/3015#discussion_r753631713 eventually as 
a classpath issue with old classes still in play.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to