ajantha-bhat commented on code in PR #6834:
URL: https://github.com/apache/iceberg/pull/6834#discussion_r1106678601
##########
data/src/main/java/org/apache/iceberg/data/IcebergGenerics.java:
##########
@@ -66,6 +67,11 @@ public ScanBuilder select(String... selectedColumns) {
return this;
}
+ public ScanBuilder select(Collection<String> columns) {
+ this.tableScan = tableScan.select(ImmutableList.copyOf(columns));
Review Comment:
Just wondering do we really need a copy of the collection again? Can't we
pass the collection directly as the below interface supports it?
https://github.com/apache/iceberg/blob/master/api/src/main/java/org/apache/iceberg/Scan.java#L87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
