hunter-cloud09 commented on code in PR #6834:
URL: https://github.com/apache/iceberg/pull/6834#discussion_r1106684445
##########
data/src/main/java/org/apache/iceberg/data/IcebergGenerics.java:
##########
@@ -66,6 +67,11 @@ public ScanBuilder select(String... selectedColumns) {
return this;
}
+ public ScanBuilder select(Collection<String> columns) {
+ this.tableScan = tableScan.select(ImmutableList.copyOf(columns));
Review Comment:
In my opinion, there is no need to copy, but I am not sure why the previous
author did this? Is there any special purpose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
