rdblue commented on code in PR #6714:
URL: https://github.com/apache/iceberg/pull/6714#discussion_r1117818870
##########
python/tests/expressions/test_visitors.py:
##########
@@ -1024,7 +1024,7 @@ def test_missing_stats(schema: Schema, manifest_no_stats:
ManifestFile) -> None:
), f"Should read when missing stats for expr: {expr}"
-def test_not(schema: Schema, manifest: ManifestFile) -> None:
+def test_not_nan(schema: Schema, manifest: ManifestFile) -> None:
Review Comment:
@Fokko, it looks like these renames were accidental. This is still testing
`Not` expressions. I think the suffix `_nan` was added to a lot of these method
names unintentionally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
