rdblue commented on code in PR #6714:
URL: https://github.com/apache/iceberg/pull/6714#discussion_r1119357809
##########
python/tests/expressions/test_visitors.py:
##########
@@ -1024,7 +1024,7 @@ def test_missing_stats(schema: Schema, manifest_no_stats:
ManifestFile) -> None:
), f"Should read when missing stats for expr: {expr}"
-def test_not(schema: Schema, manifest: ManifestFile) -> None:
+def test_not_nan(schema: Schema, manifest: ManifestFile) -> None:
Review Comment:
> The ones coming from TestMetricsEvaluatorsNaNHandling have a _nan postfix
to avoid duplicate naming. But I think we can just combine them.
I don't understand why these are NaN tests though. They are identical to the
way they were before and don't test anything specific to NaN. Am I missing
something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
