jackye1995 commented on code in PR #6650:
URL: https://github.com/apache/iceberg/pull/6650#discussion_r1120748082
##########
core/src/test/java/org/apache/iceberg/TestOverwrite.java:
##########
@@ -182,16 +182,16 @@ public void testOverwriteFailsDelete() {
@Test
public void testOverwriteWithAppendOutsideOfDelete() {
TableMetadata base = TestTables.readMetadata(TABLE_NAME);
- long baseId =
- latestSnapshot(base, branch) == null ? -1 : latestSnapshot(base,
branch).snapshotId();
+ Snapshot latestSnapshot = latestSnapshot(base, branch);
Review Comment:
maybe we can just add the `SnapshotUtil` change in this PR? I don't think we
can resolve the comments in that PR in time based on the current situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
