Fokko commented on code in PR #6970:
URL: https://github.com/apache/iceberg/pull/6970#discussion_r1125426311
##########
python/pyiceberg/io/fsspec.py:
##########
@@ -112,8 +112,15 @@ def _s3(properties: Properties) -> AbstractFileSystem:
def _adlfs(properties: Properties) -> AbstractFileSystem:
from adlfs import AzureBlobFileSystem
- fs = AzureBlobFileSystem(**properties)
- return fs
+ return AzureBlobFileSystem(
+ connection_string=properties.get("adlfs.connection-string"),
+ account_name=properties.get("adlfs.account-name"),
+ account_key=properties.get("adlfs.account-key"),
+ sas_token=properties.get("adlfs.sas-token"),
+ tenant_id=properties.get("adlfs.tenant-id"),
+ client_id=properties.get("adlfs.client-id"),
+ client_secret=properties.get("adlfs.client-secret"),
+ )
SCHEME_TO_FS = {
Review Comment:
@alaturqua Thanks for giving this a try. I'll leave out wasb for now, and we
can pick that up in a separate PR. If you feel that this is something that's
pressing, feel free to raise an issue so we can keep track of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
