Fokko commented on code in PR #6970:
URL: https://github.com/apache/iceberg/pull/6970#discussion_r1125426390
##########
python/tests/conftest.py:
##########
@@ -1277,8 +1277,8 @@ def adlfs_fsspec_fileio(request: pytest.FixtureRequest)
-> Generator[FsspecFileI
azurite_account_key = request.config.getoption("--adlfs.account-key")
azurite_connection_string =
f"DefaultEndpointsProtocol=http;AccountName={azurite_account_name};AccountKey={azurite_account_key};BlobEndpoint={azurite_url}/{azurite_account_name};"
properties = {
- "connection_string": azurite_connection_string,
- "account_name": azurite_account_name,
+ "adlfs.connection-string": azurite_connection_string,
+ "adlfs.account-name": azurite_account_name,
Review Comment:
I think we're on the same page. I'll merge this PR now, and feel free to
open up any follow-up PRs if you feel like it should be done differently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
