szehon-ho commented on code in PR #7029:
URL: https://github.com/apache/iceberg/pull/7029#discussion_r1127012441
##########
core/src/main/java/org/apache/iceberg/io/DeleteSchemaUtil.java:
##########
@@ -29,7 +29,7 @@ private static Schema pathPosSchema(Schema rowSchema) {
return new Schema(
MetadataColumns.DELETE_FILE_PATH,
MetadataColumns.DELETE_FILE_POS,
- Types.NestedField.required(
+ Types.NestedField.optional(
Review Comment:
This was necessary for the writer to allow writing position deletes with
"row", but still be ok when there is null "row".
Currently, the writer code either uses a schema with required "row" field as
is here, or a schema without the "row" field (see posPathSchema method just
below). This one with required row field is actually not used, so changing to
optional should have no impact.
This is actually more in line with the position-delete schema in the spec,
where "row" is optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
