amogh-jahagirdar commented on code in PR #6861:
URL: https://github.com/apache/iceberg/pull/6861#discussion_r1129606480
##########
api/src/main/java/org/apache/iceberg/view/ViewVersion.java:
##########
@@ -43,8 +47,7 @@ public interface ViewVersion {
long timestampMillis();
/**
- * Return the version summary such as the name of the operation that created
that version of the
- * view
+ * Return a string map of summary data for the operation that produced this
view version.
Review Comment:
Sorry for the confusion here, there's no change in spec here, it's a change
in the data model layer but since there was no implementation until now we have
some flexibility to change if desired.
We'll still serialize the `operation` in the `summary` map when writing the
metadata file, so the spec is maintained.
When we deserialize into the in memory representation, the summary map will
not contain `operation`, and instead a user would use the `operation()` API.
It's a similar model to `Snapshot` and `SnapshotParser`
Let me know if that makes sense, or if there's doubts on the API itself
after this change! cc: @rdblue @nastra @danielcweeks @jzhuge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
