amogh-jahagirdar commented on code in PR #6861:
URL: https://github.com/apache/iceberg/pull/6861#discussion_r1130428658
##########
api/src/main/java/org/apache/iceberg/view/ViewVersion.java:
##########
@@ -43,8 +47,7 @@ public interface ViewVersion {
long timestampMillis();
/**
- * Return the version summary such as the name of the operation that created
that version of the
- * view
+ * Return a string map of summary data for the operation that produced this
view version.
Review Comment:
Discussed offline with @jackye1995 instead of restricting the type of
operation up front, we can keep it open. It looks like Snapshot summary also
does has the same behavior. There's a set of recognized operations by the
Iceberg library like `append`, `replace` etc but those aren't strictly
validated when reading the metadata. So that's a similar model we can follow
here. We also don't need an enum following this logic, it can just be defined
Strings (which we can define separately when we get to the catalog
implementation for `createView` `replaceView` etc. Also we can always add an
`operation` API if it becomes to awkward to get the operation from the summary
but it's not needed at the moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
