manisin commented on code in PR #7004: URL: https://github.com/apache/iceberg/pull/7004#discussion_r1130237674
########## snowflake/src/integration/java/org/apache/iceberg/snowflake/SnowTestBase.java: ########## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.snowflake; + +import java.sql.PreparedStatement; +import java.sql.SQLException; +import org.apache.iceberg.jdbc.JdbcClientPool; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.junit.BeforeClass; +import org.junit.jupiter.api.AfterAll; + +@SuppressWarnings("VisibilityModifier") +class SnowTestBase { + + static SnowflakeCatalog snowflakeCatalog; + + static JdbcClientPool clientPool; + + protected SnowTestBase() {} + + @BeforeClass + public static void beforeAll() { + snowflakeCatalog = new SnowflakeCatalog(); + TestConfigurations configs = TestConfigurations.getInstance(); Review Comment: Favoring the separation of configurations from common utility functions in the base class for ease of readability and separation of concerns. I can move them to base class if you feel strongly about this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
