manisin commented on PR #7004: URL: https://github.com/apache/iceberg/pull/7004#issuecomment-1464372309
> > > @manisin just a general question, but is there some sort of Docker image(s) that could be used for integration testing this with [testcontainers](https://www.testcontainers.org/)? I'm curious what the general approach for integration testing is for this. The PR as it stands right now doesn't run as part of normal CI (as I commented above) and there's also no separate yml file that would set this up for its own CI runs (with the env vars that are mentioned in the README). > > > > > > @nastra there are no images/test containers to deploy and test snowflake. The approach we are considering it to add a separate yml file ( like this https://github.com/Snowflake-Labs/iceberg/blob/1f0dec004f83e1000f65cb552c360dc28eaf7559/.github/workflows/snowflake-ci.yml) and provision a snowflake deployment (with secrets onboarded to github) for integration testing with iceberg. Let me know your thoughts and suggestions. > > @manisin having a separate yml file for Snowflake integration tests should be fine, although I would probably include it in this PR. @nastra if I include the yml file in this PR then the CI will fail as we need to onboard the secrets to github for the deployment provisioned on snowflake side. I can include the yml, if it's ok to start with a failing workflow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
