rdblue commented on code in PR #7088:
URL: https://github.com/apache/iceberg/pull/7088#discussion_r1134360401
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -123,11 +124,15 @@ Map<String, String> params() {
}
public RESTSessionCatalog() {
- this(config ->
HTTPClient.builder(config).uri(config.get(CatalogProperties.URI)).build());
+ this(config ->
HTTPClient.builder(config).uri(config.get(CatalogProperties.URI)).build(),
null);
}
- RESTSessionCatalog(Function<Map<String, String>, RESTClient> clientBuilder) {
+ public RESTSessionCatalog(
+ Function<Map<String, String>, RESTClient> clientBuilder,
+ BiFunction<Map<String, String>, Object, FileIO> ioBuilder) {
Review Comment:
I think that this should pass the `SessionContext` back rather than the
wrapped identity. The session context was created by the caller anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
