electrum commented on code in PR #7088:
URL: https://github.com/apache/iceberg/pull/7088#discussion_r1134412127
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -765,24 +765,24 @@ private String fullTableName(TableIdentifier ident) {
return String.format("%s.%s", name(), ident);
}
- private FileIO newFileIO(Map<String, String> properties) {
+ private FileIO newFileIO(SessionContext context, Map<String, String>
properties) {
if (null != ioBuilder) {
- return ioBuilder.apply(properties);
+ return ioBuilder.apply(context, properties);
} else {
String ioImpl =
properties.getOrDefault(CatalogProperties.FILE_IO_IMPL,
ResolvingFileIO.class.getName());
return CatalogUtil.loadFileIO(ioImpl, properties, conf);
}
}
- private FileIO tableFileIO(Map<String, String> config) {
- if (config.isEmpty()) {
+ private FileIO tableFileIO(SessionContext context, Map<String, String>
config) {
+ if (config.isEmpty() && context.wrappedIdentity() == null) {
Review Comment:
With the change to pass the full `SessionContext` to the builder, does this
check for wrapped identity still make sense? Maybe this should be
```java
if (config.isEmpty() && ioBuilder != null)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
