JonasJ-ap commented on code in PR #7136:
URL: https://github.com/apache/iceberg/pull/7136#discussion_r1142680830
##########
python/Makefile:
##########
@@ -27,7 +27,7 @@ lint:
test:
poetry run coverage run --source=pyiceberg/ -m pytest tests/ -m
unmarked ${PYTEST_ARGS}
- poetry run coverage report -m --fail-under=90
+ poetry run coverage report -m --fail-under=88
Review Comment:
Good point! I created a new issue:
https://github.com/apache/iceberg/issues/7149.
Since the drop of test coverage is caused of exlusion of some tests related
to `s3` and `adlfs`, adding them back when computing the test coverage may also
be a solution. I argee that the top priority is to make these tests running in
the CI, so I will keep the threshold at 88% as a temporal solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
