JonasJ-ap commented on code in PR #7136:
URL: https://github.com/apache/iceberg/pull/7136#discussion_r1143607463
##########
python/Makefile:
##########
@@ -27,7 +27,7 @@ lint:
test:
poetry run coverage run --source=pyiceberg/ -m pytest tests/ -m
unmarked ${PYTEST_ARGS}
- poetry run coverage report -m --fail-under=90
+ poetry run coverage report -m --fail-under=88
Review Comment:
@Fokko Thank you for your suggestion. I added a new target called
"test-coverage" to run all the unit tests and make this the only command to be
run in the "Python CI" workflow. I also noticed that some tests utilizing
`@pytest.mark.parametrize(...)` are marked with "parametrize", so I also
included these in the "test" target.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
