sririshindra commented on code in PR #7121:
URL: https://github.com/apache/iceberg/pull/7121#discussion_r1142771731
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMigrateTableProcedure.java:
##########
@@ -106,20 +108,41 @@ public void testMigrateWithOptions() throws IOException {
sql("DROP TABLE IF EXISTS %s", tableName + "_BACKUP_");
}
- @Test
- public void testMigrateWithDropBackup() throws IOException {
+ private void testMigrateWithDropBackup(@Nullable String backupSuffix) throws
IOException {
Review Comment:
nit: I am not really familiar with the usage of the `@Nullable` annotation.
But how about directly passing the optional to the method as an argument. i.e
couldn't you just pass
`testMigrateWithDropBackup(Optional.ofNullable("_tmp"));` &
`testMigrateWithDropBackup(Optional.ofNullable(null));` rather than
constructing the optional inside the method.
I am not familiar with this pattern you are using, but if it is some sort of
standard coding practice please let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
