edgarRd commented on code in PR #7121:
URL: https://github.com/apache/iceberg/pull/7121#discussion_r1143529385
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMigrateTableProcedure.java:
##########
@@ -106,20 +108,41 @@ public void testMigrateWithOptions() throws IOException {
sql("DROP TABLE IF EXISTS %s", tableName + "_BACKUP_");
}
- @Test
- public void testMigrateWithDropBackup() throws IOException {
+ private void testMigrateWithDropBackup(@Nullable String backupSuffix) throws
IOException {
Review Comment:
I looked in the code base and the annotation patter seems preferred:
[core/src/main/java/org/apache/iceberg/puffin/PuffinCompressionCodec.java](https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/puffin/PuffinCompressionCodec.java#L62)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
