amogh-jahagirdar commented on code in PR #7150:
URL: https://github.com/apache/iceberg/pull/7150#discussion_r1143662743
##########
.palantir/revapi.yml:
##########
@@ -297,6 +297,255 @@ acceptedBreaks:
\ T) throws java.io.IOException,
com.fasterxml.jackson.core.JacksonException\
\ @
org.apache.iceberg.rest.RESTSerializers.UpdateRequirementDeserializer"
justification: "False positive - JacksonException is a subclass of
IOException"
+ - code: "java.method.numberOfParametersChanged"
+ old: "method org.apache.iceberg.DeleteFileIndex
org.apache.iceberg.MergingSnapshotProducer<ThisT>::addedDeleteFiles(org.apache.iceberg.TableMetadata,\
+ \ java.lang.Long, org.apache.iceberg.expressions.Expression,
org.apache.iceberg.util.PartitionSet)\
+ \ @ org.apache.iceberg.BaseOverwriteFiles"
+ new: "method org.apache.iceberg.DeleteFileIndex
org.apache.iceberg.MergingSnapshotProducer<ThisT>::addedDeleteFiles(org.apache.iceberg.TableMetadata,\
+ \ java.lang.Long, org.apache.iceberg.expressions.Expression,
org.apache.iceberg.util.PartitionSet,\
+ \ org.apache.iceberg.Snapshot) @ org.apache.iceberg.BaseOverwriteFiles"
+ justification: "Removing old validation APIs in favor of new validation
APIs\
Review Comment:
Sure that makes sense!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
