nastra commented on code in PR #7150:
URL: https://github.com/apache/iceberg/pull/7150#discussion_r1143672680
##########
.palantir/revapi.yml:
##########
@@ -297,10 +297,6 @@ acceptedBreaks:
\ T) throws java.io.IOException,
com.fasterxml.jackson.core.JacksonException\
\ @
org.apache.iceberg.rest.RESTSerializers.UpdateRequirementDeserializer"
justification: "False positive - JacksonException is a subclass of
IOException"
- - code: "java.method.removed"
- old: "method <T> org.apache.iceberg.io.CloseableIterable<T>
org.apache.iceberg.deletes.Deletes::filterDeleted(org.apache.iceberg.io.CloseableIterable<T>,\
- \ java.util.function.Predicate<T>)"
- justification: "Removing deprecations for 1.2.0"
Review Comment:
yeah that shouldn't change. just FYI that I've basically removed all
deprecations across iceberg-core in https://github.com/apache/iceberg/pull/7156
and I'm not seeing that change to revapi.yml. I'll wait for you to merge your
PR and rebase mine then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
