jackye1995 commented on code in PR #7066:
URL: https://github.com/apache/iceberg/pull/7066#discussion_r1145401701
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -727,6 +769,8 @@ public AwsProperties() {
this.s3SignerImpl = null;
this.allProperties = Maps.newHashMap();
+ this.clientRegion = null;
Review Comment:
I think it's still not moved? Maybe we are talking across each other. What I
meant was:
```
this.clientRegion = null;
this.clientCredentialsProvider = null;
this.clientCredentialsProviderProperties = null;
```
can be moved next to
```
this.clientAssumeRoleArn = null;
this.clientAssumeRoleTimeoutSec = CLIENT_ASSUME_ROLE_TIMEOUT_SEC_DEFAULT;
this.clientAssumeRoleExternalId = null;
this.clientAssumeRoleRegion = null;
this.clientAssumeRoleSessionName = null;
```
, and similarly
```
this.clientRegion = properties.get(CLIENT_REGION);
this.clientCredentialsProvider = properties.get(CLIENT_CREDENTIALS_PROVIDER);
this.clientCredentialsProviderProperties =
PropertyUtil.propertiesWithPrefix(properties, CREDENTIAL_PROVIDER_PREFIX);
```
and
```
private String clientRegion;
private String clientCredentialsProvider;
private final Map<String, String> clientCredentialsProviderProperties;
```
can be moved to the corresponding places where existing `clientXXX`
variables are.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
