dpaani commented on code in PR #7066:
URL: https://github.com/apache/iceberg/pull/7066#discussion_r1145597203
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -350,6 +352,37 @@ public class AwsProperties implements Serializable {
*/
public static final String CLIENT_ASSUME_ROLE_SESSION_NAME =
"client.assume-role.session-name";
+ /**
+ * Configure the AWS credentials provider used to create AWS clients. A
fully qualified concrete
+ * class with package that implements the {@link AwsCredentialsProvider}
interface is required.
+ *
+ * <p>Additionally, the implementation class must also have a create() or
create(Map) method
+ * implemented, which returns an instance of the class that provides aws
credentials provider.
+ *
+ * <p>Example:
+ *
client.credentials-provider=software.amazon.awssdk.auth.credentials.SystemPropertyCredentialsProvider
+ *
+ * <p>When set, the default client factory {@link
+ * org.apache.iceberg.aws.AwsClientFactories.DefaultAwsClientFactory} will
use this provider to
+ * get AWS credentials provided instead of reading the default credential
chain to get AWS access
+ * credentials.
+ */
+ public static final String CLIENT_CREDENTIALS_PROVIDER =
"client.credentials-provider";
+
+ /**
+ * Used by the client.credentials-provider configured value that will be
used by {@link
+ * org.apache.iceberg.aws.AwsClientFactories.DefaultAwsClientFactory} to
pass provider-specific
Review Comment:
Added @jackye1995 . thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
