aokolnychyi commented on code in PR #7177:
URL: https://github.com/apache/iceberg/pull/7177#discussion_r1145535106
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/procedures/ProcedureInput.java:
##########
@@ -62,31 +62,43 @@ public boolean isProvided(ProcedureParameter param) {
return !args.isNullAt(ordinal);
}
- public boolean bool(ProcedureParameter param, boolean defaultValue) {
+ public boolean asBoolean(ProcedureParameter param, boolean defaultValue) {
Review Comment:
I overlooked initially that we won't be able to have reasonable naming for
retrieving longs (`long` is reserved). I switched to `asXXX` like in
`PropertyUtil` and renamed all existing methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
