amogh-jahagirdar commented on code in PR #7177:
URL: https://github.com/apache/iceberg/pull/7177#discussion_r1146572529
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAncestorsOfProcedure.java:
##########
@@ -156,7 +156,7 @@ public void testInvalidAncestorOfCases() {
AssertHelpers.assertThrows(
"Should reject calls with empty table identifier",
IllegalArgumentException.class,
- "Cannot handle an empty identifier for argument table",
+ "Cannot handle an empty identifier for parameter 'table'",
Review Comment:
Does the exception message need to change?
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/procedures/ProcedureInput.java:
##########
@@ -153,7 +166,7 @@ private <K, V> Map<K, V> map(
return convertedMap;
}
- public Identifier ident(ProcedureParameter param) {
+ public Identifier asIdent(ProcedureParameter param) {
Review Comment:
I'm not sure we actually want to use `asIdent` here, I think it makes sense
for obtaining the other types but ident by itself should be sufficient
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
