jackye1995 commented on code in PR #7066:
URL: https://github.com/apache/iceberg/pull/7066#discussion_r1145683231
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -1070,11 +1124,25 @@ public Map<String, String> httpClientProperties() {
*
S3Client.builder().applyMutation(awsProperties::applyS3CredentialConfigurations)
* </pre>
*/
- public <T extends S3ClientBuilder> void applyS3CredentialConfigurations(T
builder) {
+ public <T extends AwsClientBuilder> void applyS3CredentialConfigurations(T
builder) {
builder.credentialsProvider(
credentialsProvider(s3AccessKeyId, s3SecretAccessKey, s3SessionToken));
}
+ /**
+ * Configure the credentials for AWS clients.
+ *
+ * <p>Sample usage:
+ *
+ * <pre>
+ *
S3Client.builder().applyMutation(awsProperties::applyCredentialConfigurations)
+ * </pre>
+ */
+ public <T extends AwsClientBuilder> void applyCredentialConfigurations(T
builder) {
Review Comment:
I am suggesting the method name to be `applyClientCredentialConfigurations`
instead of `applyCredentialConfigurations`, which has one more word **Client**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
