wangyinsheng commented on code in PR #7144:
URL: https://github.com/apache/iceberg/pull/7144#discussion_r1147616700
##########
api/src/test/java/org/apache/iceberg/TestHelpers.java:
##########
@@ -137,6 +142,18 @@ public static void assertSerializedAndLoadedMetadata(Table
expected, Table actua
Assert.assertEquals("History must match", expected.history(),
actual.history());
}
+ public static void assertSerializedMetricsReporter(
Review Comment:
done
##########
api/src/test/java/org/apache/iceberg/TestHelpers.java:
##########
@@ -137,6 +142,18 @@ public static void assertSerializedAndLoadedMetadata(Table
expected, Table actua
Assert.assertEquals("History must match", expected.history(),
actual.history());
}
+ public static void assertSerializedMetricsReporter(
+ MetricsReporter expected, MetricsReporter actual) {
+ Assert.assertNotNull("metrics reporter from serializableTable should not
be null", actual);
+ Assert.assertTrue(
+ "metrics reporter from serializableTable should be instance of
TestMetricsReporter",
+ actual instanceof TestMetricsReporter);
+ Assert.assertEquals(
+ "metrics reporter from serializableTable should equals the one from
origin table",
+ expected,
+ actual);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
