nastra commented on code in PR #7144:
URL: https://github.com/apache/iceberg/pull/7144#discussion_r1149339713
##########
core/src/test/java/org/apache/iceberg/TestTables.java:
##########
@@ -264,8 +265,17 @@ public void commit(TableMetadata base, TableMetadata
updatedMetadata) {
throw new CommitFailedException("Injected failure");
}
Integer version = VERSIONS.get(tableName);
+ String metadataLocation =
Review Comment:
I still think those changes are not necessary. The test passed fine for me
without having those changes
##########
core/src/main/java/org/apache/iceberg/SerializableTable.java:
##########
@@ -247,6 +252,18 @@ public Map<String, SnapshotRef> refs() {
return refs;
}
+ @Override
+ public MetricsReporter metricsReporter() {
+ if (lazyMetricsReporter == null) {
+ synchronized (this) {
+ if (lazyMetricsReporter == null) {
+ lazyMetricsReporter =
CatalogUtil.loadMetricsReporter(this.metricsReporterProperties);
Review Comment:
sorry my bad, you're right. it should be the catalog properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
