szehon-ho commented on code in PR #5659: URL: https://github.com/apache/iceberg/pull/5659#discussion_r1159190765
########## core/src/main/java/org/apache/iceberg/SystemProperties.java: ########## @@ -18,7 +18,9 @@ */ package org.apache.iceberg; -/** Configuration properties that are controlled by Java system properties. */ +/** + * Configuration properties that are controlled by Java system properties or environmental variable Review Comment: This class is now a bit confusing, should we just make another class? I dont think there's that many places that need this, that we need to always call these utils? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
