hililiwei commented on code in PR #7254:
URL: https://github.com/apache/iceberg/pull/7254#discussion_r1159314226
##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkTableSource.java:
##########
@@ -422,8 +422,9 @@ public void testFilterPushDownInNull() {
Assert.assertEquals("Should have 1 record", 1, result.size());
Assert.assertEquals(
"Should produce the expected record", Row.of(1, "iceberg", 10.0),
result.get(0));
+ String expectedScan = "ref(name=\"data\") == \"iceberg\"";
Review Comment:
In previous versions, Flink did not push down the `IN ()` to the source
tableļ¼ `@Override
public Result applyFilters(List<ResolvedExpression> flinkFilters) `) if it
contained `NULL`. This time it removes the `NULL` and pushes the rest down.
I'm not sure whether this change was done by Flink itself or because it
upgraded the version of Calcite to to 1.29.0. Let me look into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
