hililiwei commented on code in PR #7254:
URL: https://github.com/apache/iceberg/pull/7254#discussion_r1160433815
##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkTableSource.java:
##########
@@ -422,8 +422,9 @@ public void testFilterPushDownInNull() {
Assert.assertEquals("Should have 1 record", 1, result.size());
Assert.assertEquals(
"Should produce the expected record", Row.of(1, "iceberg", 10.0),
result.get(0));
+ String expectedScan = "ref(name=\"data\") == \"iceberg\"";
Review Comment:
> you are saying Flink skips the `null` for predicate pushdown? if yes,
please add it the comment. it will also be great we can link to a Flink jira
(if there is) for future improvement on pushdown with `null` value.
As a side note, NULL has no meaning in `in ()`, and it cannot query data
which is NULL, it is correct to ignore it here. So we don't have to push it
down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
