ConeyLiu commented on code in PR #5659: URL: https://github.com/apache/iceberg/pull/5659#discussion_r1161054994
########## core/src/main/java/org/apache/iceberg/SystemProperties.java: ########## @@ -18,7 +18,9 @@ */ package org.apache.iceberg; -/** Configuration properties that are controlled by Java system properties. */ +/** + * Configuration properties that are controlled by Java system properties or environmental variable Review Comment: Using both system property and environment variable to control some settings are very common usage, for example: `ARROW_ENABLE_NULL_CHECK_FOR_GET` and `arrow.enable_null_check_for_get`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
